Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swift test should warn when --filter excludes all tests (_à la_ XCTest.) #128

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

swift test should warn when --filter excludes all tests (_à la_ XCTest.) #128

wants to merge 1 commit into from

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Nov 18, 2023 •
edited

When using XCTest and swift test --filter, if all tests are filtered out a diagnostic of the form:

warning: No matching test cases were run

Is emitted by SwiftPM. We should have a similar warning we emit from swift-testing in this scenario.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
swift test should warn when --filter excludes all tests (_à la_ X…
695293d 
…CTest.)

When using XCTest and `swift test --filter`, if all tests are filtered out a diagnostic of the form:

> warning: No matching test cases were run

Is emitted by SwiftPM. We should have a similar warning we emit from swift-testing in this scenario.
@grynspan grynspan changed the title swift test should warn when --filter excludes all tests (_à la_ X… swift test should warn when --filter excludes all tests (_à la_ XCTest.) Nov 18, 2023
@grynspan
Copy link
Contributor Author

Draft for now because we may end up needing to implement the relevant logic in a single location in SwiftPM so that the message reflects the overall output, not per-library output. TBD.

@grynspan grynspan self-assigned this Nov 20, 2023
@grynspan grynspan added the bug Something isn't working label Nov 20, 2023
@grynspan grynspan added the swiftpm-integration Swift Package Manager integration label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery Awaiting requested review from stmontgomery stmontgomery will be requested when the pull request is marked ready for review stmontgomery is a code owner

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann dennisweissmann will be requested when the pull request is marked ready for review dennisweissmann is a code owner

@briancroom briancroom Awaiting requested review from briancroom briancroom will be requested when the pull request is marked ready for review briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski SeanROlszewski will be requested when the pull request is marked ready for review SeanROlszewski is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff will be requested when the pull request is marked ready for review suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels
bug Something isn't working swiftpm-integration Swift Package Manager integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@grynspan