Split .bug() into two taking a URL or a number.
#401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
added
bug
|
@swift-ci please test |
grynspan
force-pushed
the
jgrynspan/refactor-bug-trait
branch
from
bcf900f
to
916b815
Compare
grynspan
force-pushed
the
jgrynspan/refactor-bug-trait
branch
from
916b815
to
93603ae
Compare
grynspan
force-pushed
the
jgrynspan/refactor-bug-trait
branch
from
93603ae
to
106764a
Compare
grynspan
requested review from
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
This PR changes the initializers for `.bug()` from ones taking an undecorated
and unspecified "identifier" to ones taking either a URL (as a string) or a
numeric ID ("bug number.")
The existing interface is ambiguous to tools authors seeking to integrate with
it. They must treat _every_ bug as potentially containing a URL with fallback
paths if a bug's ID cannot be parsed as a URL. By splitting URLs and numbers up
into two separate properties, tools authors can provide reliable, distinct
interfaces for bugs known by number vs. those known by URL.
grynspan
force-pushed
the
jgrynspan/refactor-bug-trait
branch
from
106764a
to
a7ea40f
Compare
|
@swift-ci please test |
stmontgomery
approved these changes
May 24, 2024
|
Windows failure is a known compiler issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the initializers for
.bug()from ones taking an undecorated and unspecified "identifier" to ones taking either a URL (as a string) or a numeric ID ("bug number.")The existing interface is ambiguous to tools authors seeking to integrate with it. They must treat every bug as potentially containing a URL with fallback paths if a bug's ID cannot be parsed as a URL. By splitting URLs and numbers up into two separate properties, tools authors can provide reliable, distinct interfaces for bugs known by number vs. those known by URL.
Checklist: