[6.0][Concurrency] Remove last usages of @_unsafeInheritExecutor #73569
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: We still had a few stray uses of @_unsafeInheritExecutor which we are intending to stop using entirely. The uses were in task cancellation handler (which I noticed), and withTaskGroup*.
Scope/Impact: Use the official way of inheriting isolation, rather than the fragile unofficial attribute. Impact on users is more correct inheritance of context, making APIs usable in actors in Swift 6 mode.
Risk: Low, Verified ABI method remain and only adds #isolation new API
Testing: CI testing, added tests to verify behavior of task cancellation handler inside actor
Reviewed by: @hborla
Original PR: #73568
Radar: rdar://127874129