Using LLVM style diagnostics for caching build for now #73575
Merged
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
requested review from
akyrtzi,
rintaro,
DougGregor and
benlangmuir
|
@swift-ci please smoke test |
benlangmuir
reviewed
May 10, 2024
cachemeifyoucan
force-pushed
the
eng/PR-127530204
branch
from
ee40055
to
8a541b6
Compare
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-127530204
branch
from
8a541b6
to
073f189
Compare
|
@swift-ci please smoke test |
|
ping |
akyrtzi
approved these changes
May 22, 2024
When caching is enabled, using swift style diagnotics can lead to crashes due to some uninitialized variables. Even more, the swift style diagnostics is not going to render the same when replay from the cache since the currect caching diagnostics processor is not capture all information that is needed to render diagnostis from SwiftSyntax. Temprarily using llvm style for caching builds. rdar://127530204
cachemeifyoucan
force-pushed
the
eng/PR-127530204
branch
from
073f189
to
68c755e
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift style diagnostics is not completely covered by CachedDiagnosticsProcessor yet for them to be replayed correctly when caching is enabled. Temporarily using LLVM style diagnostics when caching is enabled.