[Autodiff] Adds logic to generate specialized functions in the closure-spec pass #73596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@eeckstein could I get a quick approval on this? |
|
@swift-ci please test |
|
@swift-ci please test macos |
|
@swift-ci please test |
|
@shahmishal swift-ci seems to be broken. |
|
@jkshtj Do you have commit access to swift repo? |
I do |
|
I see the trigger comment has a extra space: |
|
@swift-ci please test |
|
Fixed the issue with Windows trigger by adding you to the allow list. |
|
@swift-ci test Windows |
Ah, I'm sorry for the mistake. Looks like that was it. Is there a way to make these swift-ci invocations agnostic to certain cosmetic things - capitalization, spaces etc.? |
Addresses some other surfacial feedback as well.
|
@swift-ci please test |
|
@swift-ci please test linux |
|
@swift-ci please test |
|
@swift-ci test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approved in this PR.
PR to merge into Swift main branch.