[Dependency Scanning] Specify Source Locations For Missing Module Dependencies #73600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
force-pushed
the
DepScanSourceLocsV2
branch
from
4a7e534
to
01d7b66
Compare
artemcm
force-pushed
the
DepScanSourceLocsV2
branch
2 times, most recently
from
44d745d
to
2a7f2ff
Compare
|
@swift-ci test |
artemcm
commented
May 13, 2024
| // CHECK-NEXT: 2 | // swift-module-flags: -module-name Z | ||
| // CHECK-NEXT: 3 | import missing_module | ||
| // CHECK-NEXT: | |- error: Unable to find module dependency: 'missing_module' | ||
| // CHECK-NEXT: | |- note: a dependency of Swift module 'Z': '{{.*}}{{/|\\}}Z.swiftinterface' |
There was a problem hiding this comment.
A follow-up change will associate these notes with their corresponding source location of the importer of the given module in the dependency chain.
nkcsgexi
approved these changes
May 13, 2024
artemcm
force-pushed
the
DepScanSourceLocsV2
branch
from
2a7f2ff
to
5b03799
Compare
owenv
approved these changes
May 13, 2024
artemcm
force-pushed
the
DepScanSourceLocsV2
branch
from
5b03799
to
c85a126
Compare
|
Waiting on apple/llvm-project#8754 to land and auto-merge before this can land. |
|
@swift-ci test |
artemcm
force-pushed
the
DepScanSourceLocsV2
branch
from
c85a126
to
09b641e
Compare
|
@swift-ci test |
artemcm
force-pushed
the
DepScanSourceLocsV2
branch
from
09b641e
to
9ac78b5
Compare
1 similar comment
artemcm
force-pushed
the
DepScanSourceLocsV2
branch
from
9ac78b5
to
b738bc4
Compare
artemcm
force-pushed
the
DepScanSourceLocsV2
branch
from
b738bc4
to
dbb0757
Compare
1 similar comment
|
@swift-ci Please Build Toolchain Ubuntu 22.04 |
|
@swift-ci Please Build Toolchain Ubuntu 22.04 (arm64) |
artemcm
force-pushed
the
DepScanSourceLocsV2
branch
from
dbb0757
to
c310947
Compare
…endencies This change modifies the dependency scanner to keep track of source locations of each encountered 'import' statement, in order to be able to emit diagnostics with source locations if an import failed to resolve. - Keep track of each 'import' statement's source buffer, line number, and column number when adding it. The dependency scanner utilizes separate compilation instances, and therefore separate Source Managers for scanning `import` statements of user sources and textual interfaces of Swift dependencies. Since import resolution may happen in the main scanner compilation instance while the `import` itself was found by an interface-scanning sub-instance, we cannot simply hold on to the import's `SourceLoc`. - Add libSwiftScan API for diagnostics to carry above source locations to clients.
artemcm
force-pushed
the
DepScanSourceLocsV2
branch
from
c310947
to
9aeadd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the dependency scanner to keep track of source locations of each encountered
importstatement, in order to be able to emit diagnostics with source locations if an import failed to resolve.importstatement's source buffer, line number, and column number when adding it. The dependency scanner utilizes separate compilation instances, and therefore separate Source Managers for scanningimportstatements of user sources and textual interfaces of Swift dependencies. Since import resolution may happen in the main scanner compilation instance while theimportitself was found by an interface-scanning sub-instance, we cannot simply hold on to the import'sSourceLoc.Instead of unlocatable:
we will now get rich output: