[CMake] allow custom options when building the compiler with debug info #73603
+76
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test WebAssembly |
|
@swift-ci please build toolchain |
|
The WebAssembly failure is the same as the main job |
edymtt
commented
May 14, 2024
utils/swift_build_support/swift_build_support/products/swift.py
Outdated
Show resolved
Hide resolved
Currently those are hardcoded to `-g`, but in some Apple internal configurations we would like to change them. There are other part of the build system that hardcode `-g` (e.g. in `SwiftCompilerSources` and `AddSwiftStdlib.cmake`), but we are not interested in those at the moment -- we will address those in the future if need be. Supports rdar://127503136
edymtt
force-pushed
the
edymtt/swift-args-for-debug-info-non-lto
branch
from
11b7dcc
to
ce0e620
Compare
|
@swift-ci please test |
|
@swift-ci please test WebAssembly |
|
@swift-ci please build toolchain |
al45tair
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently those are hardcoded to
-g, but in some Apple internal configurations we would like to change them.There are other part of the build system that hardcode
-g(e.g. inSwiftCompilerSourcesandAddSwiftStdlib.cmake), but we are not interested in those at the moment -- we will address those in the future if need be.Supports rdar://127503136