Skip to content

Commit

Permalink
Remove playwright to use @playwright/test
Browse files Browse the repository at this point in the history
With the playwright v1.34.0 release a breaking change was introduced where running `npx playwright test` won't work when both `playwright` and `@playwright/test` are installed.

See https://github.com/microsoft/playwright/releases/tag/v1.34.0

The image is also pinned to `:v1.34.0` to resolve the correct SHA digest, see:

microsoft/playwright#23186
  • Loading branch information
Ekhorn committed May 21, 2023
1 parent 2d509f9 commit 68554b0
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .gitlab-ci.yml
Expand Up @@ -681,7 +681,7 @@ lighthouse:
playwright:
stage: end 2 end
extends: .yarn
image: mcr.microsoft.com/playwright
image: mcr.microsoft.com/playwright:v1.34.0
needs:
- job: provision review
optional: true
Expand Down
3 changes: 1 addition & 2 deletions packages/e2e/package.json
Expand Up @@ -28,8 +28,7 @@
"dependencies": {
"@fortawesome/fontawesome-free": "^6.0.0",
"@playwright/test": "^1.0.0",
"bulma": "0.9.3",
"playwright": "^1.0.0"
"bulma": "0.9.3"
},
"engines": {
"node": ">=18"
Expand Down
7 changes: 0 additions & 7 deletions yarn.lock
Expand Up @@ -11830,13 +11830,6 @@ playwright-core@1.34.0, playwright-core@^1.0.0:
resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.34.0.tgz#6a8f05c657400677591ed82b6749ef7e120a152d"
integrity sha512-fMUY1+iR6kYbJF/EsOOqzBA99ZHXbw9sYPNjwA4X/oV0hVF/1aGlWYBGPVUEqxBkGANDKMziYoOdKGU5DIP5Gg==

playwright@^1.0.0:
version "1.34.0"
resolved "https://registry.yarnpkg.com/playwright/-/playwright-1.34.0.tgz#c9e9b080e75f1f2679a61bc93aee76d8a8556589"
integrity sha512-fh+Q7fw7fPg2jSjDUNgo46PbKNTKQCYbeYXXbMm1hTbhPc0V62WM6h/pqWLTW0tqjfu8TCLdx7tECd/2AbYaHg==
dependencies:
playwright-core "1.34.0"

pluralize@^8.0.0:
version "8.0.0"
resolved "https://registry.yarnpkg.com/pluralize/-/pluralize-8.0.0.tgz#1a6fa16a38d12a1901e0320fa017051c539ce3b1"
Expand Down

0 comments on commit 68554b0

Please sign in to comment.