Fix test suite for Node.js 19.1 #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The header setters are now no-op functions since Node.js 19.1. Nock, the http mocking library we use for our transmitter tests uses these setters so our tests break. This commit uses the `rawHeaders` attribute instead to get green tests until the issue is fixed in either side. More info: nodejs/node#45510
tombruijn
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header setters are now no-op functions since Node.js 19.1. Nock, the http mocking library we use for our transmitter tests uses these setters so our tests break. This commit uses the
rawHeadersattribute instead to get green tests until the issue is fixed on either side.More info: nodejs/node#45510
[skip changeset]