New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: changes for CD tech debt #33231
Conversation
WalkthroughWalkthroughThe recent update introduces a new permission, Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Description
Creating a new permission for Application, which is APPLICATION_DELETE_PAGES, this permission would be used to derive DELETE_PAGES permission for those permissionGroupIds which don't have DELETE_APPLICATIONS permission.
Once such example is CD bot role. although it requires permission to delete pages and entities inside it, we don't want to provide permission for deleting application. This could be achieved by providing DELETE_PAGES permission, however when creating new pages, the permission would still be derived from application and it would lack the particular permission group id in DELETE_PAGES permissionGroups.
Fixes #
Issue Number
or
Fixes
Issue URL
Warning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.All"
馃攳 Cypress test results
Tip
馃煝 馃煝 馃煝 All cypress tests have passed! 馃帀 馃帀 馃帀
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9013034630
Commit: 9c01c08
Cypress dashboard url: Click here!
Communication
Should the DevRel and Marketing teams inform users about this change?