Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix queries if node class label is added #99

Merged
merged 1 commit into from Nov 16, 2022
Merged

Fix queries if node class label is added #99

merged 1 commit into from Nov 16, 2022

Commits on Nov 14, 2022

  1. Fix queries if node class label is added 

    Prometheus keeps series "alive" for 5 minutes after they get dropped from a scrape target. This leads to a slight overlap in the `kube_node_labels` metric if a node is relabeled.

This commit prioritizes series having a node class labels over series without.

This still does not work if a node class label changes from non-empty to non-empty but that should never happen. I don't think there is a generic way to handle this case.
    @bastjan
    bastjan committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    4f5510d View commit details
    Browse the repository at this point in the history