Cleanup after aggregator_v2_api and concurrent token features #13247
+215
−597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13247 +/- ##
=========================================
- Coverage 57.5% 57.5% -0.1%
=========================================
Files 832 833 +1
Lines 198522 198662 +140
=========================================
+ Hits 114269 114280 +11
- Misses 84253 84382 +129 ☔ View full report in Codecov by Sentry. |
igor-aptos
force-pushed
the
igor/deprecating_rolled_out_features
branch
from
01d8c4c
to
2bb15be
Compare
igor-aptos
requested review from
msmouse,
grao1991,
JoshLind,
a team,
gregnazario,
brianolson,
banool,
bchocho,
sasha8,
zekun000,
ibalajiarun,
junkil-park,
alinush,
heliuchuan,
vgao1996 and
0xmaayan
as code owners
igor-aptos
removed request for
alinush,
msmouse,
ibalajiarun,
grao1991,
JoshLind,
heliuchuan,
sasha8,
banool,
junkil-park,
vgao1996,
0xmaayan and
zekun000
igor-aptos
force-pushed
the
igor/deprecating_rolled_out_features
branch
from
2bb15be
to
59de22a
Compare
Those two features will not be reverted. If there is any issue with the aggregators, feature that controls the fallback will be used, but API will still work.
igor-aptos
force-pushed
the
igor/deprecating_rolled_out_features
branch
from
59de22a
to
26b579d
Compare
| public fun get_auids(): u64 { APTOS_UNIQUE_IDENTIFIERS } | ||
| public fun get_auids(): u64 { | ||
| // Deployed to production, and disabling deprecated. | ||
| error::invalid_argument(EINVALID_FEATURE) |
There was a problem hiding this comment.
Probably permission_denied or something like this would be better? With a new error code which is like EFEATURE_CANNOT_BE_DISABLED or something like that
| public fun get_aggregator_v2_api_feature(): u64 { AGGREGATOR_V2_API } | ||
| public fun get_aggregator_v2_api_feature(): u64 { | ||
| // API fully rolled out, cannot be reverted any more | ||
| abort error::invalid_argument(EINVALID_FEATURE) |
| let feature = features::get_concurrent_token_v2_feature(); | ||
| let agg_feature = features::get_aggregator_v2_api_feature(); | ||
| let auid_feature = features::get_auids(); | ||
| let module_event_feature = features::get_module_event_feature(); |
There was a problem hiding this comment.
module event feature also cannot be reverted?
There was a problem hiding this comment.
it can be reverted, but default is true - so we don't need to enable it in this test.
though that can potentially also be cleaned up @lightmark
| }; | ||
|
|
||
| (index, name) | ||
| // If aggregator_api_enabled, we always populate newly added fields |
There was a problem hiding this comment.
The comment seems off? aggregator_api_enabled is always enabled
21 tasks
|
addressed comments, ping to other reviewers |
igor-aptos
force-pushed
the
igor/deprecating_rolled_out_features
branch
from
45f0ee3
to
b889ad1
Compare
movekevin
approved these changes
May 23, 2024
georgemitenkov
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those two features will not be reverted.
If there is any issue with the aggregators, feature that controls the fallback will be used, but API will still work.
This simplifies the complicated nested if conditions in collection.move and token.move
Description
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Key Areas to Review
Checklist