Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create reject_unstable_bytecode.yaml #13268

Merged

Conversation

rahxephon89
Copy link
Contributor

@rahxephon89 rahxephon89 commented May 13, 2024

Description

This PR creates the release yaml file to enable the feature flag REJECT_UNSTABLE_BYTECODE.

Copy link

trunk-io bot commented May 13, 2024

⏱️ 9h 14m total CI duration on this PR
Job Cumulative Duration Recent Runs
windows-build 1h 20m 🟩🟩
rust-targeted-unit-tests 1h 16m 🟩🟩🟩
rust-smoke-tests 1h 11m 🟩🟩
rust-unit-tests 1h 6m 🟩🟩
execution-performance / single-node-performance 50m 🟩🟩
rust-move-tests 33m 🟩🟩🟩
forge-e2e-test / forge 28m 🟩🟩
forge-compat-test / forge 26m 🟩🟩
rust-images / rust-all 25m 🟩🟩
rust-lints 23m 🟩🟩🟩
cli-e2e-tests / run-cli-tests 19m 🟩🟥
run-tests-main-branch 17m 🟩🟩🟩🟩
rust-build-cached-packages 12m 🟩🟩
check 8m 🟩🟩
general-lints 6m 🟩🟩🟩
check-dynamic-deps 5m 🟩🟩🟩🟩
node-api-compatibility-tests / node-api-compatibility-tests 2m 🟩🟩
semgrep/ci 1m 🟩🟩🟩🟩
file_change_determinator 47s 🟩🟩🟩🟩
file_change_determinator 47s 🟩🟩🟩🟩
permission-check 30s 🟩🟩🟩🟩
file_change_determinator 25s 🟩🟩
execution-performance / file_change_determinator 21s 🟩🟩
permission-check 12s 🟩🟩🟩🟩
permission-check 12s 🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩
permission-check 6s 🟩🟩
determine-docker-build-metadata 4s 🟩🟩

🚨 4 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-build-cached-packages 8m 5m +59%
rust-lints 10m 6m +58%
rust-targeted-unit-tests 27m 18m +47%
cli-e2e-tests / run-cli-tests 9m 6m +40%

settingsfeedbackdocs ⋅ learn more about trunk.io

@rahxephon89 rahxephon89 force-pushed the teng/enable-feature-flag-for-metadata branch from 05c2bfc to ed53797 Compare May 13, 2024 19:00
@rahxephon89 rahxephon89 marked this pull request as ready for review May 13, 2024 19:01
@rahxephon89 rahxephon89 requested a review from sherry-x May 13, 2024 20:56
@rahxephon89 rahxephon89 enabled auto-merge (squash) May 18, 2024 20:00
@rahxephon89 rahxephon89 disabled auto-merge May 18, 2024 20:14

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@rahxephon89 rahxephon89 enabled auto-merge (squash) May 20, 2024 17:05

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> ed53797ceed1c32dddfbf7451201464dbdececf8

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> ed53797ceed1c32dddfbf7451201464dbdececf8 (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 6657 txn/s, latency: 4967 ms, (p50: 4800 ms, p90: 8400 ms, p99: 9900 ms), latency samples: 233000
2. Upgrading first Validator to new version: ed53797ceed1c32dddfbf7451201464dbdececf8
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1759 txn/s, latency: 16516 ms, (p50: 18100 ms, p90: 24200 ms, p99: 24400 ms), latency samples: 89740
3. Upgrading rest of first batch to new version: ed53797ceed1c32dddfbf7451201464dbdececf8
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1683 txn/s, latency: 16108 ms, (p50: 18700 ms, p90: 22400 ms, p99: 24100 ms), latency samples: 90920
4. upgrading second batch to new version: ed53797ceed1c32dddfbf7451201464dbdececf8
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3620 txn/s, latency: 8823 ms, (p50: 9600 ms, p90: 12600 ms, p99: 12700 ms), latency samples: 144820
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> ed53797ceed1c32dddfbf7451201464dbdececf8 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on ed53797ceed1c32dddfbf7451201464dbdececf8

two traffics test: inner traffic : committed: 7977 txn/s, latency: 4910 ms, (p50: 4700 ms, p90: 5900 ms, p99: 10200 ms), latency samples: 3446180
two traffics test : committed: 100 txn/s, latency: 1929 ms, (p50: 1900 ms, p90: 2200 ms, p99: 4400 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.205, avg: 0.200", "QsPosToProposal: max: 0.239, avg: 0.226", "ConsensusProposalToOrdered: max: 0.450, avg: 0.398", "ConsensusOrderedToCommit: max: 0.385, avg: 0.370", "ConsensusProposalToCommit: max: 0.778, avg: 0.769"]
Max round gap was 1 [limit 4] at version 1699805. Max no progress secs was 4.336599 [limit 15] at version 1699805.
Test Ok

@rahxephon89 rahxephon89 requested a review from wrwg May 20, 2024 19:06
@rahxephon89 rahxephon89 merged commit 4b9a259 into aptos-release-v1.12 May 20, 2024
142 of 143 checks passed
@rahxephon89 rahxephon89 deleted the teng/enable-feature-flag-for-metadata branch May 20, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants