Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prover] Added DeFi examples #13281

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

junkil-park
Copy link
Contributor

@junkil-park junkil-park commented May 14, 2024

Description

  • Created two DeFi examples, revamping the previous rounding error examples
    • One is a simple dex pool based on Uniswap V1
    • Another is a simple reserve-backed currency system
  • Defined the safety properties for the examples, and proved them with Move Prover

Copy link

trunk-io bot commented May 14, 2024

⏱️ 2h 37m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-unit-coverage 1h 🟩🟩🟩
rust-move-tests 36m 🟩🟩🟩
rust-targeted-unit-tests 17m 🟩🟩🟩
rust-lints 17m 🟩🟩🟩
run-tests-main-branch 14m 🟩🟩🟩
general-lints 5m 🟩🟩🟩
check-dynamic-deps 4m 🟩🟩🟩
semgrep/ci 1m 🟩🟩🟩
file_change_determinator 35s 🟩🟩🟩
file_change_determinator 29s 🟩🟩🟩
permission-check 12s 🟩🟩🟩
permission-check 9s 🟩🟩🟩
permission-check 8s 🟩🟩🟩
permission-check 7s 🟩🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-targeted-unit-tests 6m 19m -71%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.6%. Comparing base (7719765) to head (da1da17).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13281   +/-   ##
=======================================
  Coverage    57.6%    57.6%           
=======================================
  Files         834      834           
  Lines      198396   198396           
=======================================
+ Hits       114325   114367   +42     
+ Misses      84071    84029   -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rahxephon89 rahxephon89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

- Created two DeFi examples, revamping the rounding error examples
  - One is a simple dex pool based on Uniswap V1
  - Another is a simple reserve-backed currency system
- Defined the safety properties for the examples, and proved them with Move Prover
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants