Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support aws/aws-cli for masOS + Windows #14005

Closed
Gowiem opened this issue Jul 24, 2023 · 5 comments
Closed

Support aws/aws-cli for masOS + Windows #14005

Gowiem opened this issue Jul 24, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@Gowiem
Copy link
Contributor

Gowiem commented Jul 24, 2023

package name

aws/aws-cli

Overview

Opening this up for discussion. It would be great to see the aws-cli package supported on macOS and windows as this would further aqua's ability to be the go-to, one timer installer for my team and clients. Right now, it only supports linux and I'd like to see if we could change that. Have any attempts been made? Any thoughts here?

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Jul 24, 2023

Thank you for opening this issue.

aws-cli was added by the following pull requests.

IIRC, we couldn't support macOS and Windows because AWS CLI's installation URLs didn't include the version string.

e.g. https://awscli.amazonaws.com/AWSCLIV2.pkg

aqua is a version manager, so package's download URLs must be different by version.

But I found download URLs of AWS CLI include the version string now.

https://docs.aws.amazon.com/cli/latest/userguide/getting-started-version.html

So the above issue was resolved.

aqua supports PKG format, but doesn't support .msi format.

So I guess aqua can support macOS but can't support Windows for now.

I'm not familiar with .msi format, so I'm not sure if aqua will be able to support .msi format.

@suzuki-shunsuke
Copy link
Member

IIRC, we couldn't support macOS and Windows because AWS CLI's installation URLs didn't include the version string.

I found a comment.

I thought aqua can support aws CLI in macOS, but unfortunately aqua couldn't because AWS CLI's PKG URL doesn't have the version, so aqua couldn't distinguish the version.

https://awscli.amazonaws.com/AWSCLIV2.pkg

@suzuki-shunsuke
Copy link
Member

This is still draft, but I could install AWS CLI on macOS.

I'm not sure if it really works properly, so I'll take a look further.

@suzuki-shunsuke
Copy link
Member

Supported macOS. 🎉
I created an issue for Windows.

@suzuki-shunsuke
Copy link
Member

I close this issue.
I created an issue for Windows instead.

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants