Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Windows' .msi format #2126

Open
suzuki-shunsuke opened this issue Jul 25, 2023 · 4 comments
Open

Support Windows' .msi format #2126

suzuki-shunsuke opened this issue Jul 25, 2023 · 4 comments
Labels

Comments

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Jul 25, 2023

Feature Overview

Support unarchiving Windows' .msi format.

Why is the feature needed?

Some packages are distributed by .msi format.

For example, AWS CLI is distributed by .msi format.

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Jul 25, 2023
@suzuki-shunsuke
Copy link
Member Author

suzuki-shunsuke commented Jul 25, 2023

I'm not familiar with Windows, but it seems .msi files can be unarchived by msiexec command.

https://atmarkit.itmedia.co.jp/ait/articles/0703/02/news130.html
https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/msiexec
https://vamdemicsystem.black/windows/%E3%80%90windows%E3%80%91msi%E3%83%95%E3%82%A1%E3%82%A4%E3%83%AB%E3%82%92%E5%B1%95%E9%96%8B%E3%81%99%E3%82%8B
http://nanoappli.com/blog/archives/478

/a: unarchive
/qn: quiet

start /wait msiexec /a hoge.msi targetdir="<absolute path of the destination directory>" /qn

@sheldonhull
Copy link

Not sure you want to go down that road. Chocolatey is better for that, as it runs installers/custom scripts. Not at all what what you want from this app.

MSI is an installer, not an executable binary.
Typically, that has an entire instruction set to install and extract to paths.

If they aren't building the aws cli as a standalone binary and are still doing a python distribution then it seems like they are likely bundling the python version and more in the msi. I just looked at the repo and it seems to style be python.

@suzuki-shunsuke
Copy link
Member Author

suzuki-shunsuke commented Jul 28, 2023

We could support some formats such as .pkg and .dmg before.

They included executable files and could be unarchived in AQUA_ROOT_DIR.

I'm not familiar with .msi format, but if aqua could support this format in the same way, it would be fine.

Typically, that has an entire instruction set to install and extract to paths.

If .msi format requires to execute arbitrary external commands, we don't want aqua to run them for security reason.

@suzuki-shunsuke
Copy link
Member Author

I think this is nice to have. I don't think this is important for now because almost packages don't need this feature and this is only for Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

2 participants