Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add toshimaru/nyan #22316

Merged
merged 3 commits into from Apr 29, 2024
Merged

Conversation

ishii1648
Copy link
Contributor

@ishii1648 ishii1648 commented Apr 28, 2024

toshimaru/nyan: Colored cat command which supports syntax highlighting.

$ aqua g -i toshimaru/nyan

Check List

@ishii1648 ishii1648 marked this pull request as ready for review April 28, 2024 17:25
@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Apr 29, 2024
@suzuki-shunsuke
Copy link
Member

Thank you for your contribution!

supported_envs:
- linux
- darwin
rosetta2: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think rosetta2 isn't necessary at the latest version.

https://github.com/toshimaru/nyan/releases/tag/v1.0.10

nyan_Darwin_arm64.tar.gz

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmdx s toshimaru/nyan generates the different code.
Please follow the contribution guide as you checked the check list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for skipping over the important chapter about contributing. Thank you for pointing it out and for handling the corrections until the merge. As a user, I'm delighted that such a fantastic tool(toshimaru/nyan) has been added to the aqua-registry.

@suzuki-shunsuke suzuki-shunsuke merged commit 2c5d075 into aquaproj:main Apr 29, 2024
16 checks passed
@suzuki-shunsuke suzuki-shunsuke added this to the v4.167.1 milestone Apr 29, 2024
@suzuki-shunsuke
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants