Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add DeNA/unity-meta-check/unity-meta-check-junit #22862

Conversation

ponkio-o
Copy link
Sponsor Contributor

@ponkio-o ponkio-o commented May 14, 2024

DeNA/unity-meta-check/unity-meta-check-junit: Reporter for Jenkins compatible XML based JUnit reports. It need a result of unity-meta-check from stdin.

Check List

How to confirm if this package works well

Reviewers aren't necessarily familiar with this package, so please describe how to confirm if this package works well.
Please confirm if this package works well yourself as much as possible.

Command and output

root@927907d6c78d:/workspace# unity-meta-check-junit --help
usage: unity-meta-check-junit [<options>] [<path>]

Save a JUnit report file for the result from unity-meta-check via STDIN.

  <path>
        output path to write JUnit report

OPTIONS
  -version
        print version

EXAMPLE USAGES
  $ unity-meta-check <options> | unity-meta-check-junit path/to/junit-report.xml
  $ unity-meta-check <options> | unity-meta-check-junit path/to/junit-report.xml | <other-unity-meta-check-tool>

If files such as configuration file are needed, please share them.

Reference

[DeNA/unity-meta-check/unity-meta-check-junit](https://github.com/DeNA/unity-meta-check): Reporter for Jenkins compatible XML based JUnit reports. It need a result of unity-meta-check from stdin.
@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label May 14, 2024
@suzuki-shunsuke
Copy link
Member

Thank you always!

Copy link
Member

@suzuki-shunsuke suzuki-shunsuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding version_overrides, we stopped relying on base settings as much as possible.
This means we stopped defining settings such as asset, format, windows_arm_emulation, and so on on the base settings.
Merge with base settings makes code DRY, but it's difficult to update settings when settings of new versions are changed because the update of the base settings affects all version override.
By stopping to merge settings, we can update settings by simply adding a new version override and updating the last version_constraint.
Perhaps we would be able to automate the update in future too.

@suzuki-shunsuke
Copy link
Member

Regarding version_overrides, we stopped relying on base settings as much as possible. This means we stopped defining settings such as asset, format, windows_arm_emulation, and so on on the base settings. Merge with base settings makes code DRY, but it's difficult to update settings when settings of new versions are changed because the update of the base settings affects all version override. By stopping to merge settings, we can update settings by simply adding a new version override and updating the last version_constraint. Perhaps we would be able to automate the update in future too.

e84ea5e Fixed.

@suzuki-shunsuke suzuki-shunsuke merged commit 417496b into aquaproj:main May 14, 2024
16 checks passed
@suzuki-shunsuke suzuki-shunsuke added this to the v4.180.0 milestone May 14, 2024
@suzuki-shunsuke
Copy link
Member

v4.180.0 is out 🎉
https://github.com/aquaproj/aqua-registry/releases/tag/v4.180.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants