-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add DeNA/unity-meta-check/unity-meta-check-junit #22862
feat: add DeNA/unity-meta-check/unity-meta-check-junit #22862
Conversation
[DeNA/unity-meta-check/unity-meta-check-junit](https://github.com/DeNA/unity-meta-check): Reporter for Jenkins compatible XML based JUnit reports. It need a result of unity-meta-check from stdin.
Thank you always! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding version_overrides, we stopped relying on base settings as much as possible.
This means we stopped defining settings such as asset, format, windows_arm_emulation, and so on on the base settings.
Merge with base settings makes code DRY, but it's difficult to update settings when settings of new versions are changed because the update of the base settings affects all version override.
By stopping to merge settings, we can update settings by simply adding a new version override and updating the last version_constraint.
Perhaps we would be able to automate the update in future too.
…on merge of version_overrides
e84ea5e Fixed. |
This reverts commit 417496b.
v4.180.0 is out 🎉 |
DeNA/unity-meta-check/unity-meta-check-junit: Reporter for Jenkins compatible XML based JUnit reports. It need a result of unity-meta-check from stdin.
Check List
Require signed commits
, so all commits must be signedHow to confirm if this package works well
Reviewers aren't necessarily familiar with this package, so please describe how to confirm if this package works well.
Please confirm if this package works well yourself as much as possible.
Command and output
If files such as configuration file are needed, please share them.
Reference