Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix 'tf-var' arg not passing when using 'sarif' format #311

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Fix 'tf-var' arg not passing when using 'sarif' format #311

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fd205f
fix_tfvar_with_sarif_bug
antigenius0910 Feb 17, 2024
4dc05f2
add more description so we don't confuse user
antigenius0910 Feb 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#!/bin/bash
set -e

while getopts "a:b:c:d:e:f:g:h:i:j:k:l:m:n:o:p:q:r:s:t:u:v:x:z:" o; do
case "${o}" in
a)
Expand Down Expand Up @@ -137,6 +138,7 @@ if [ $skipDirs ];then
fi
if [ $tfVars ] && [ "$scanType" == "config" ];then
ARGS="$ARGS --tf-vars $tfVars"
SARIF_ARGS="$SARIF_ARGS --tf-vars $tfVars"
fi

if [ $trivyIgnores ];then
Expand Down Expand Up @@ -186,7 +188,8 @@ if [ "${format}" == "sarif" ] && [ "${limitSeveritiesForSARIF}" != "true" ]; the
# regardless of severity level specified in this report.
# This is a feature, not a bug :)
echo "Building SARIF report with options: ${SARIF_ARGS}" "${artifactRef}"
trivy --quiet ${scanType} --format sarif --output ${output} $SARIF_ARGS ${artifactRef}
echo "Ignore all severity level being defined since limit-severities-for-sarif: false"
trivy ${scanType} --format sarif --output ${output} $SARIF_ARGS ${artifactRef}
elif [ $trivyConfig ]; then
echo "Running Trivy with trivy.yaml config from: " $trivyConfig
trivy --config $trivyConfig ${scanType} ${artifactRef}
Expand Down