Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(misconf): Improve misconfig scan messaging #6307

Closed
wants to merge 1 commit into from
Closed

fix(misconf): Improve misconfig scan messaging #6307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/scanner/local/scan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ func (s Scanner) misconfsToResults(misconfs []ftypes.Misconfiguration, options t

// MisconfsToResults is exported for trivy-plugin-aqua purposes only
func (s Scanner) MisconfsToResults(misconfs []ftypes.Misconfiguration) types.Results {
log.Logger.Infof("Detected config files: %d", len(misconfs))
log.Logger.Infof("Detected files with misconfig: %d", len(misconfs))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is correct to say that files with misconfig are detected, because the list of misconfigurations may only contain successfully passed checks.

var results types.Results
for _, misconf := range misconfs {
log.Logger.Debugf("Scanned config file: %s", misconf.FilePath)
Expand Down