replace String with JSON.stringify #68
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is clearly a bug, because when I have value of sourceMaps in my config like ``` sourceMaps: urlPrefix: /var/task ``` It's serialized like `[object Object]` and that's what I see on environment variable in lambda configuration. I am not sure what this variables is needed for (is it needed at all?), but definitely it shouldn't look like that. Could it be that for other cases here we should replace `String(...)` with `JSON.stringify(...)`?
|
@arabold hey! did you have a chance to review it? perhaps it makes sense to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is clearly a bug, because when I have value of sourceMaps in my config like
It's serialized like
[object Object]and that's what I see on environment variable in lambda configuration. I am not sure what this variables is needed for (is it needed at all?), but definitely it shouldn't look like that.Could it be that for other cases here we should replace
String(...)withJSON.stringify(...)?