Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update less-loader options #243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update less-loader options #243

wants to merge 1 commit into from

Conversation

dbwcooper
Copy link

Use lessOptions instead of the options at less-loader@6.0.0
#241
#231

 Use  lessOptions instead of the options at less-loader@6.0.0
@SamKirkland
Copy link

also #242

@AO19
Copy link

AO19 commented May 26, 2020

@arackaf could you take a look at this?

@arackaf
Copy link
Owner

arackaf commented May 26, 2020

Hey all - I'm not really involved with this project anymore. Is anyone here interested in becoming a maintainer?

@Anish-Agnihotri
Copy link
Collaborator

Hey folks,

I've received maintainer access from Adam since he's unable to contribute/involved with the project anymore. First priority is to fix the css-loader/less-loader issues currently prevalent in the master branch due to the changed options format.

There was a working change implemented in #185 on the next branch, which can be further enhanced by @edwardwang0302's changes in #214. These were held off from master due to them being breaking changes, but due to the backlog of issues, I'm going to run through the existing PRS tomorrow, test each of them, and then make a fix-merge into master so that the css-loader/less-loader issues can be fixed immediately.

Does that sound good? Open to thoughts/implementation details.

@Anish-Agnihotri
Copy link
Collaborator

@xyy94813 PR #185 with the new implementation of getStyleLoaders should fix #242. I'll check tomorrow and merge if so.

@xyy94813
Copy link

@Anish-Agnihotri

Yeah!!!!! This PR #185 is what I am going to do.
I found it has been merge into next branch.
I'm very excited that someone has already done this.

@leojh
Copy link

leojh commented May 27, 2020

any timeframe for a release?

@Anish-Agnihotri
Copy link
Collaborator

@leojh Testing and working on it right now. Pushing for a release hopefully before EOD tomorrow (if not, latest-Friday).

The changes are already implemented in the next branch. You can test by installing customize-cra@next to see if that resolves your issues. But, since it's a breaking-change I want to make sure everything is in order before I merge into master.

@leojh
Copy link

leojh commented May 27, 2020

thank you will do! thank you for keeping this package going.

@leojh
Copy link

leojh commented May 27, 2020

works!

@Anish-Agnihotri
Copy link
Collaborator

Hey folks,

The changes in the @next branch have been pushed upstream and merged into master. Please follow the migration guide in #253, which will have you nest your configuration in the lessOptions object.

Hopefully this resolves a majority of the issues in the thread. Please do let me know if you still run into issues; I'll keep this PR thread open for a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants