Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrinkwrap file mismatch #593

Closed
kernelwhisperer opened this issue Jul 7, 2019 · 1 comment
Closed

Shrinkwrap file mismatch #593

kernelwhisperer opened this issue Jul 7, 2019 · 1 comment
Assignees
Labels
🛠️ toolkit Toolkit for accessing Aragon utilities programmatically.

Comments

@kernelwhisperer
Copy link
Contributor

kernelwhisperer commented Jul 7, 2019

🐛 Bug Report

On master we have this shrinkwrap file:

    "eth-block-tracker": {
      "version": "2.3.1",
      "resolved": "https://registry.npmjs.org/eth-block-tracker/-/eth-block-tracker-2.3.1.tgz",
      "integrity": "sha512-NamWuMBIl8kmkJFVj8WzGatySTzQPQag4Xr677yFxdVtIxACFbL/dQowk0MzEqIKk93U1TwY3MjVU6mOcwZnKA==",
      "requires": {
        "async-eventemitter": "github:ahultgren/async-eventemitter#fa06e39e56786ba541c180061dbf2c0a5bbf951c",
  ...

But on npm, this is published:

    "eth-block-tracker": {
      "version": "2.3.1",
      "resolved": "https://registry.npmjs.org/eth-block-tracker/-/eth-block-tracker-2.3.1.tgz",
      "integrity": "sha512-NamWuMBIl8kmkJFVj8WzGatySTzQPQag4Xr677yFxdVtIxACFbL/dQowk0MzEqIKk93U1TwY3MjVU6mOcwZnKA==",
      "requires": {
        "async-eventemitter": "async-eventemitter@github:ahultgren/async-eventemitter#fa06e39e56786ba541c180061dbf2c0a5bbf951c",
  ...

This is a known issue, which we solve with our custom made script, (see the Dependencies doc for more).

The issue here is that lerna, during the publish process, changes these files...
You can see it in action here: https://travis-ci.org/aragon/aragon-cli/jobs/555428095#L2511

Temporary solution:

cd packages/aragon-cli
npm version patch
git add -A
git commit -m "Bump version"
npm publish --tag nightly

Reported this in the lerna repo: lerna/lerna#2168

@kernelwhisperer kernelwhisperer added the 🛠️ toolkit Toolkit for accessing Aragon utilities programmatically. label Jul 7, 2019
@kernelwhisperer kernelwhisperer self-assigned this Jul 7, 2019
@kernelwhisperer kernelwhisperer added this to To do in Aragon Mesh Team via automation Jul 7, 2019
@kernelwhisperer kernelwhisperer mentioned this issue Jul 7, 2019
4 tasks
@kernelwhisperer kernelwhisperer mentioned this issue Jul 18, 2019
4 tasks
@0xGabi
Copy link
Contributor

0xGabi commented Aug 7, 2019

@0x6431346e I think we can close this one now

@0xGabi 0xGabi closed this as completed Aug 7, 2019
Aragon Mesh Team automation moved this from To do to Done Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ toolkit Toolkit for accessing Aragon utilities programmatically.
Projects
No open projects
Development

No branches or pull requests

2 participants