Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ipfs cmd refactor #636

Merged
merged 9 commits into from
Jul 18, 2019
Merged

Ipfs cmd refactor #636

merged 9 commits into from
Jul 18, 2019

Conversation

kernelwhisperer
Copy link
Contributor

馃 Pull Request

This should have been 3 PRs, but I've categorized them in different commits:

馃毃 Test instructions

鉁旓笍 PR Todo

  • Include links to related issues/PRs
  • Update unit tests for this change
  • Update the relevant documentation
  • Clear dependencies on other modules that have to be released before merging this

@kernelwhisperer kernelwhisperer added this to In progress in Aragon Mesh Team via automation Jul 18, 2019
@kernelwhisperer
Copy link
Contributor Author

@sohkai could you rename aragon-cli-utils to @aragon/cli-utils and publish it?

@kernelwhisperer kernelwhisperer moved this from In progress to Review in Aragon Mesh Team Jul 18, 2019
@kernelwhisperer
Copy link
Contributor Author

--eth-rpc seems to have been removed since a long time ago: https://github.com/aragon/aragon-cli/blob/v2.2.0/src/cli.js#L93

@sohkai
Copy link
Contributor

sohkai commented Jul 18, 2019

@0x6431346e I've published @aragon/cli-utils@0.0.1 (74d681e) and given you and @0xGabi access to it :).

0xGabi
0xGabi approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@0xGabi 0xGabi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first step towards having cli-utils package.

I also removed --eth-rpc on #541 馃憤

@0xGabi 0xGabi merged commit e590bc2 into master Jul 18, 2019
Aragon Mesh Team automation moved this from Review to Done Jul 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the ipfs-cmd-refactor branch July 18, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xGabi 0xGabi 0xGabi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Aragon Mesh Team
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kernelwhisperer @sohkai @0xGabi