Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot fix #173

Merged
merged 2 commits into from
Jun 12, 2020
Merged

Hot fix #173

merged 2 commits into from
Jun 12, 2020

Conversation

0xGabi
Copy link
Contributor

@0xGabi 0xGabi commented Jun 12, 2020

馃 Pull Request Description

Point to a hot-fix client version until we figure out the issue on the client local network.

Updates buidler to the latest version and include an improved log message that address #170

@0xGabi 0xGabi merged commit 944a150 into master Jun 12, 2020
@0xGabi 0xGabi deleted the hot-fix branch June 12, 2020 18:59
"@nomiclabs/buidler-etherscan": "^1.3.0",
"@nomiclabs/buidler-truffle5": "^1.3.0",
"@nomiclabs/buidler-web3": "^1.3.0",
"web3": "^1.2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that web3@1.2.8 introduced a significant change to the ABI encoded (ethers@5). Not sure if it has any impact to us, or how deeply we use web3 in our plugin, but something worth checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants