-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/global lease manager #20832
Draft
mchacki
wants to merge
28
commits into
devel
Choose a base branch
from
feature/global-lease-manager
base: devel
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature/global lease manager #20832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly and can be added into a list
…ger. Not used yet
…o it. Also added simplistic thread safetey mechanism to the framework
…ailes during MockCluster setup, hence disabled for now. Added stubs for 'abort leases for server' API.
…est for Tombstones.
…s on the Query. Abort on Coordinator not yet implemented.
…and shutdown all queries using it. NOTE: Tests do not yet compile
…ill already be cleaned up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
WIP
This adds a general purpose Lease manager. The idea behind this is that we have a unified "cleanup on remote-server-down" mechanism, that is inspectable from the Outside. First target use-cases here: A query should have a Lease of on all Servers it uses shards of, in turn those servers should hand out a lease to the Coordinator starting the query. This way we are sure that if one server crashes, or somehow destroyed the query, the other participants are informed. This will allow us to erase system internal timeouts on Queries. Same for Transactions.
Checklist
Related Information
(Please reference tickets / specification / other PRs etc)