-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup/sut checker modules #20880
Merged
Merged
Cleanup/sut checker modules #20880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a way to scan test infrastructure for commandline options and their defaults - move most options out of `testing.js` into the modules that work with these options - options used by instance.js and instance-manager.js will end in instance-manager.js - introduce API function to add documentation including duplicate checking - remove redundand options from testsuites - locate and fix duplicates - move portManager into its own file
naushniki
approved these changes
May 7, 2024
jsteemann
reviewed
May 24, 2024
jsteemann
reviewed
May 24, 2024
jsteemann
reviewed
May 24, 2024
jsteemann
reviewed
May 24, 2024
jsteemann
reviewed
May 24, 2024
js/client/modules/@arangodb/testutils/sutcheckers/collections.js
Outdated
Show resolved
Hide resolved
jsteemann
reviewed
May 24, 2024
js/client/modules/@arangodb/testutils/sutcheckers/collections.js
Outdated
Show resolved
Hide resolved
jsteemann
reviewed
May 24, 2024
jsteemann
reviewed
May 24, 2024
jsteemann
reviewed
May 24, 2024
jsteemann
reviewed
May 24, 2024
jsteemann
reviewed
May 24, 2024
jsteemann
reviewed
May 24, 2024
jsteemann
reviewed
May 24, 2024
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
…s.js Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
…ions. Do away with cut'n' paste leftovers.
jsteemann
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to the best of my knowledge, but I do not consider myself an expert on this area of code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
make SUT health checkers modular.