Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

honor maxProjections options for MaterializeNode projections #20938

Merged
merged 1 commit into from
May 16, 2024
Merged

honor maxProjections options for MaterializeNode projections #20938

merged 1 commit into from
May 16, 2024

Conversation

jsteemann
Copy link
Contributor

Scope & Purpose

Honor maxProjections option in IndexNodes when the IndexNode data is later materialized using a MaterializeNode.

  • 馃挬 Bugfix
  • 馃崟 New feature
  • 馃敟 Performance improvement
  • 馃敤 Refactoring/simplification

Checklist

  • Tests
    • Regression tests
    • C++ Unit tests
    • integration tests
    • resilience tests
  • 馃摉 CHANGELOG entry made
  • 馃摎 documentation written (release notes, API changes, ...)
  • Backports
    • Backport for 3.12.0: -
    • Backport for 3.11: -
    • Backport for 3.10: -

Related Information

  • Docs PR:
  • Enterprise PR:
  • GitHub issue / Jira ticket:
  • Design document:

@jsteemann jsteemann added this to the devel milestone May 15, 2024
@jsteemann jsteemann requested a review from a team as a code owner May 15, 2024 12:30
@cla-bot cla-bot bot added the cla-signed label May 15, 2024
neunhoef
neunhoef approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Simran-B
Simran-B approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@Simran-B Simran-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested manually, limiting to a lower-than-default value as well as increasing the limit for projections

@neunhoef neunhoef merged commit b9500f4 into devel May 16, 2024
6 checks passed
@neunhoef neunhoef deleted the bug-fix/honor-max-projections-in-materialize branch May 16, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neunhoef neunhoef neunhoef approved these changes

@Simran-B Simran-B Simran-B approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
devel
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsteemann @neunhoef @Simran-B