Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Backport of #20937
Enterprise companion PR: https://github.com/arangodb/enterprise/pull/1485
BTS-1868: fix TSan errors
https://arangodb.atlassian.net/browse/BTS-1868
This PR makes 2 relevant changes:
stop()
andunprepare()
, but if these were not called, retry requests could leak.AuthenticationFeature::INSTANCE
was a raw pointer and was accessed and modified without synchronization. This PR turns it into an atomic pointer, so that TSan does not report data races when the member is accessed.As this PR also removes some includes from central header files and replaces them by forward definitions, a lot of unrelated files also had to be changed so that the previously transitively included header files would be included there.
Checklist
Related Information