Bug fix 3.11/hotbackup restore analyzers #20940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t do not exist in HB. Properly react to agency response, if the input is of illegal format.
jsteemann
reviewed
May 15, 2024
| // Now create the regression. In version 3.6 the entry /arango/Plan/Analyzers did not exist. | ||
|
|
||
|
|
||
| assertTrue(readAgencyValueAt("Plan/Analyzers") !== undefined, "We should have analyzers in plan by default."); |
There was a problem hiding this comment.
nit: instead of assertTrue(x !== undefined) we could use assertNotUndefined(x), which is more legible.
There was a problem hiding this comment.
Ah nice, did not know this existed!
goedderz
approved these changes
May 15, 2024
Comment on lines
+6963
to
+6965
| return {TRI_ERROR_HOT_BACKUP_INTERNAL, | ||
| "Failed to restore agency plan from Hotbackup. Please contact " | ||
| "ArangoDB support immediately."}; |
There was a problem hiding this comment.
Should this be an ADB_PROD_ASSERT?
mchacki
added a commit
that referenced
this pull request
May 21, 2024
* Applied fix to set empty objects instead of none for Plan entries that do not exist in HB. Properly react to agency response, if the input is of illegal format. * Actually report an error if replanning of the AgencyPlan fails * Added a failure point for test. * Added hotbackup regression tests * Applied clang-format --------- Co-authored-by: Vadim Kondratev <vadim@arangodb.com>
19 tasks
CryptoNinjaGeek
pushed a commit
that referenced
this pull request
May 23, 2024
* Bug fix 3.11/hotbackup restore analyzers (#20940) * Applied fix to set empty objects instead of none for Plan entries that do not exist in HB. Properly react to agency response, if the input is of illegal format. * Actually report an error if replanning of the AgencyPlan fails * Added a failure point for test. * Added hotbackup regression tests * Applied clang-format --------- Co-authored-by: Vadim Kondratev <vadim@arangodb.com> * Bug fix 3.11/hotbackup community test (#20947) * Replaced asserts on undefined with convenience method: * Fixed a race condtion after Hotbackup Restore, and after adding a DBServer, the List of Databases could be empty. * Added CHANGELOG entry --------- Co-authored-by: Vadim Kondratev <vadim@arangodb.com> * Added lost code from cherry-pick --------- Co-authored-by: Vadim Kondratev <vadim@arangodb.com> Co-authored-by: jsteemann <jsteemann@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
This PR fixes a bug which happens on Hotbackup restore, that only shows up on clusters that started with 3.6 or older. And was upgraded ever since. If such a deployment goes to 3.11.8, and wants to restore a backup this will fail.
Checklist
Related Information
(Please reference tickets / specification / other PRs etc)