Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add privileged config option #58

Merged
merged 5 commits into from
Apr 22, 2024
Merged

add privileged config option #58

merged 5 commits into from
Apr 22, 2024

Conversation

mfleader
Copy link
Member

Changes introduced with this PR

Add podman privileged as a config option for the deployer.

Privileged container execution reference.


By contributing to this repository, I agree to the contribution guidelines.

@mfleader mfleader marked this pull request as ready for review April 19, 2024 19:32
Copy link

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this have to be translated to --privileged somewhere for the podman command?

And any intent to do this for the docker deployer as well? (Not that I'm complaining: everyone should use podman anyway. 😆 )

@dustinblack dustinblack linked an issue Apr 22, 2024 that may be closed by this pull request
@mfleader
Copy link
Member Author

mfleader commented Apr 22, 2024

Doesn't this have to be translated to --privileged somewhere for the podman command?

And any intent to do this for the docker deployer as well? (Not that I'm complaining: everyone should use podman anyway. 😆 )

Afaik, no, but I will verify more completely.

I've never seen any program where you have to enable the use of a CLI option through the configuration of another file. Usually, they are just different entry points with different levels of precedence to alter same the behavior.

@mfleader
Copy link
Member Author

Doesn't this have to be translated to --privileged somewhere for the podman command?

And any intent to do this for the docker deployer as well? (Not that I'm complaining: everyone should use podman anyway. 😆 )

Okay yeah I did need to implement the behavior the argsbuilder interface and call it in Deploy(). I thought we generated our own container runtime toml config, as in containers.confg.

@mfleader mfleader self-assigned this Apr 22, 2024
Copy link
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; one suggestion.

schema.go Outdated Show resolved Hide resolved
@mfleader mfleader merged commit 9d1fe15 into main Apr 22, 2024
2 checks passed
@mfleader mfleader deleted the privileged branch April 22, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for --privileged execution
3 participants