Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine test suite #74

Merged
merged 11 commits into from
Feb 5, 2024
Merged

Refine test suite #74

merged 11 commits into from
Feb 5, 2024

Conversation

mfleader
Copy link
Member

Changes introduced with this PR

Bind range variables to a locally scoped variable inside the loop.


By contributing to this repository, I agree to the contribution guidelines.

Copy link
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just one question.

schema/units_test.go Show resolved Hide resolved
webbnh

This comment was marked as resolved.

Copy link
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@mfleader mfleader merged commit a481c35 into main Feb 5, 2024
3 checks passed
@mfleader mfleader deleted the refine-tests branch February 5, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants