Export Helper Function #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredoconnell
approved these changes
Apr 17, 2024
dbutenhof
approved these changes
Apr 18, 2024
dbutenhof
approved these changes
Apr 18, 2024
webbnh
reviewed
Apr 18, 2024
Comment on lines
+662
to
+676
| // Try plain object schema | ||
| objectSchemaType, ok := typeOrData.(*ObjectSchema) | ||
| if ok { | ||
| return objectSchemaType, true | ||
| } | ||
| // Next, try ref schema | ||
| refSchemaType, ok := typeOrData.(*RefSchema) | ||
| if ok { | ||
| return refSchemaType.GetObject(), true | ||
| } | ||
| // Next, try scope schema. | ||
| scopeSchemaType, ok := typeOrData.(*ScopeSchema) | ||
| if ok { | ||
| return scopeSchemaType.Objects()[scopeSchemaType.Root()], true | ||
| } |
There was a problem hiding this comment.
This seems like it should be a switch statement, no?
switch v := typeOrData.(type) {
case *ObjectSchema:
return v, true
case *RefSchema:
return v.GetObject(), true
case *ScopeSchema:
return v.Objects()[scopeSchemaType.Root()], true
}There was a problem hiding this comment.
It's worth trying. If it fails, lots of tests for ValidateCompatibility will fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
Facilitate type casting schemas to
ObjectSchemaoutside of thepluginsdkpackage.convertToObjectSchemaConvertToObjectSchemamethod as a package functionBy contributing to this repository, I agree to the contribution guidelines.