upgrade golang version #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbutenhof
approved these changes
Jan 30, 2024
webbnh
reviewed
Jan 30, 2024
Comment on lines
+11
to
+13
| labelStrEmpty := l.String() | ||
| if l.String() != "" { | ||
| t.Fatalf("Incorrect label string: %s", l.String()) | ||
| t.Fatalf("Incorrect label string: %s", labelStrEmpty) |
There was a problem hiding this comment.
You missed a spot: in the other two changes, you replaced the l.string() reference with a reference to the new local variable; you didn't do so, here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
golangci-lintto 1.52.2.TestMessageLabels.By contributing to this repository, I agree to the contribution guidelines.