Fixed cases when candidates sequences was braked #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They prevent user data from leaving the browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone! Thanks so much for creating this app! This tool is perfect!⭐
Testing version from @rmsy in PR #21 i notice that sometimes de sequence brakes, making the game start again, example
Candidates:
Sometimes the script returns this kind of combinations for example:
Note that this breaks the gift sequence forcing the game start again.
This PR fix this forcing the sequence returned in all times with no breaks, for exemple:
There is a validator function, uncomment this line to se the sequence printed in console for tests
Sometimes (20% of tests) the sequence fails and raise in error, i dont have more time to try fix this, but for me just clicking in generate again resolves.