feat: bigint literals without as const #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
reviewed
Nov 21, 2020
| @@ -25,6 +25,10 @@ import * as t from '../sources'; | |||
| if (t.isLiteral(42)(foo)) { | |||
| const bar: 42 = foo; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Any way to remove the messages at the top? 🤔
There was a problem hiding this comment.
🤔 I tried using a nested tsconfig.json, but it only gets rid of the editor warning, so it's still present if type-checking from the root. Maybe some magic with project references? Or should we just add a @ts-expect-error to the line above?
There was a problem hiding this comment.
I think the best is to use ES2020 in the general tsconfig.json, and create a tsconfig.build.json that extends the main one but downgrades the target.
There was a problem hiding this comment.
Looks like we can't set ES2020 as the target for development, as TS won't transpile optional chaining anymore, which isn't supported by Node 12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
t.isLiteraldidn't support bigint literals withoutas const.