Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(dropdown): the label is not aligned #3059

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ikxin
Copy link

@ikxin ikxin commented Apr 3, 2024

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Component style change
  • Typescript definition change
  • Documentation change
  • Coding style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Breaking change
  • Others

Background and context

当 Dropdown 组件的 Dsubmenu 内容长度不一致时标签没有对齐 #3057

Solution

将 Dsubmenu 元素中的标签元素宽度设置为 100%

How is the change tested?

Changelog

Component Changelog(CN) Changelog(EN) Related issues
dropdown 修复标签未对齐 fix the label is not aligned #3057

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others
    should be submitted to main branch)

Other information

Copy link

codesandbox bot commented Apr 3, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@ikxin ikxin changed the title style(dropdown): the label is not aligned (#3057) style(dropdown): the label is not aligned Apr 3, 2024
@oljc
Copy link
Member

oljc commented Apr 4, 2024

@ikxin
使用选择器 如果没有设置图标时 suffix 将变成第二个 span 元素导致与预期不符:
image

希望有空改一下这个 PR,使用 flex 1,此外参考其他已合并 PR 完善补充一下 Changelog😀
image

@ikxin
Copy link
Author

ikxin commented Apr 6, 2024

@LIjiAngChen8 感谢建议,已更新 pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants