Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix some components missing props definitions #3076

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

wehuss
Copy link
Contributor

@wehuss wehuss commented Apr 12, 2024

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Component style change
  • Typescript definition change
  • Documentation change
  • Coding style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Breaking change
  • Others

Background and context

DatePickerTypographyInput这三个组件中的子组件没有继承父组件的propsemits,从而导致在tsx中使用时产生类型错误

image
image
image

Solution

使用extends选项继承父组件的propsemits
image

How is the change tested?

Changelog

Component Changelog(CN) Changelog(EN) Related issues
date-picker 修复子组件缺少props定义问题 fix missing props definitions close #2801
typography 修复子组件缺少props定义问题 fix missing props definitions close #2801
input 修复子组件缺少props定义问题 fix missing props definitions close #2801

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others
    should be submitted to main branch)

Other information

Copy link

codesandbox bot commented Apr 12, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement feature enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arco compoent 的tsx 的形式,类型声明有问题?
2 participants