Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typings #716

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Improve typings #716

wants to merge 1 commit into from

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Oct 21, 2023

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant
motivation and context. List any dependencies that are required for this change.

Related # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take
action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Environment:

  • OS:
  • package-name:
  • NodeJS:

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose
the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

💻 Website Preview

The latest changes are available as preview in: https://dc617051.fets.pages.dev

@github-actions
Copy link
Contributor

✅ Benchmark Results

     ✓ no_errors{server:node-http,mode:no-schema}
     ✓ expected_result{server:node-http,mode:no-schema}
     ✓ no_errors{server:node-http,mode:json-schema}
     ✓ expected_result{server:node-http,mode:json-schema}
     ✓ no_errors{server:uWebSockets,mode:no-schema}
     ✓ expected_result{server:uWebSockets,mode:no-schema}
     ✓ no_errors{server:uWebSockets,mode:json-schema}
     ✓ expected_result{server:uWebSockets,mode:json-schema}

     checks......................................: 100.00% ✓ 961392      ✗ 0     
     data_received...............................: 87 MB   726 kB/s
     data_sent...................................: 61 MB   509 kB/s
     http_req_blocked............................: avg=1.28µs   min=800ns   med=1.1µs   max=875.42µs p(90)=1.6µs   p(95)=1.9µs  
     http_req_connecting.........................: avg=3ns      min=0s      med=0s      max=809.22µs p(90)=0s      p(95)=0s     
     http_req_duration...........................: avg=167.53µs min=97.8µs  med=150.5µs max=26.42ms  p(90)=195.6µs p(95)=219.5µs
       { expected_response:true }................: avg=167.53µs min=97.8µs  med=150.5µs max=26.42ms  p(90)=195.6µs p(95)=219.5µs
     ✓ { server:node-http,mode:json-schema }.....: avg=181.98µs min=122.7µs med=167.6µs max=15.18ms  p(90)=211.3µs p(95)=231.8µs
     ✓ { server:node-http,mode:no-schema }.......: avg=178.93µs min=109.7µs med=157.4µs max=26.42ms  p(90)=214.2µs p(95)=235.3µs
     ✓ { server:uWebSockets,mode:json-schema }...: avg=157.83µs min=104.3µs med=143.7µs max=10.93ms  p(90)=175.7µs p(95)=191.8µs
     ✓ { server:uWebSockets,mode:no-schema }.....: avg=154.24µs min=97.8µs  med=137.4µs max=11.19ms  p(90)=171.9µs p(95)=192.4µs
     http_req_failed.............................: 0.00%   ✓ 0           ✗ 480696
     http_req_receiving..........................: avg=19.11µs  min=10.5µs  med=16.1µs  max=5.53ms   p(90)=27.1µs  p(95)=31.7µs 
     http_req_sending............................: avg=7.59µs   min=4.8µs   med=6µs     max=12.08ms  p(90)=10.8µs  p(95)=12.4µs 
     http_req_tls_handshaking....................: avg=0s       min=0s      med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting............................: avg=140.83µs min=77.6µs  med=125.8µs max=23.7ms   p(90)=163.7µs p(95)=184.4µs
     http_reqs...................................: 480696  4005.660115/s
     iteration_duration..........................: avg=243.82µs min=157.6µs med=222.4µs max=26.61ms  p(90)=285.5µs p(95)=313.8µs
     iterations..................................: 480696  4005.660115/s
     vus.........................................: 1       min=1         max=1   
     vus_max.....................................: 2       min=2         max=2   

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant