Independence #529
Closed
Independence #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest changes of this PR are available as alpha in npm: Quickly update your package.json by running: |
kamilkisiela
force-pushed
the
share-tools
branch
3 times, most recently
from
a4109a8
to
6d021cc
Compare
kamilkisiela
force-pushed
the
share-tools
branch
from
6d021cc
to
c46c577
Compare
ardatan
reviewed
Apr 6, 2020
| definitions: [info.operation, ...fragments], | ||
| }; | ||
|
|
||
| return fetcher({ |
There was a problem hiding this comment.
This will cause some issues later. Let’s say remote schema is merged with another schema. It will send the whole query to the remote schema as well so some weird errors might be thrown. And also this will send the query for each root field.
ardatan/graphql-tools#1346 (comment)
This issue looks similar but it is for links. (Links work in a different way)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
graphql-tools@graphql-toolkit/types- contains only types like IResolvers etc@graphql-toolkit/version- checks the version of GraphQL (v14+ exports versionInfo)@graphql-toolkit/schema- has makeExecutableSchema (+remote) and other related functions