fix and actually introduce dynamic selection sets (#1798)

fix typos! add tests!
ardatan · Jul 19, 2020 · 9a6aeb4 · 9a6aeb4
1 parent 479892b
commit 9a6aeb4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/packages/stitch/src/stitchingInfo.ts b/packages/stitch/src/stitchingInfo.ts
@@ -207,11 +207,11 @@ export function completeStitchingInfo(stitchingInfo: StitchingInfo, resolvers: I
       const field = type[fieldName] as IFieldResolverOptions;
       if (field.selectionSet) {
         if (typeof field.selectionSet === 'function') {
-          if (!(typeName in selectionSetsByField)) {
+          if (!(typeName in dynamicSelectionSetsByField)) {
             dynamicSelectionSetsByField[typeName] = Object.create(null);
           }
 
-          if (!(fieldName in selectionSetsByField[typeName])) {
+          if (!(fieldName in dynamicSelectionSetsByField[typeName])) {
             dynamicSelectionSetsByField[typeName][fieldName] = [];
           }
 

diff --git a/packages/stitch/tests/alternateStitchSchemas.test.ts b/packages/stitch/tests/alternateStitchSchemas.test.ts
@@ -11,6 +11,7 @@ import {
   GraphQLFieldConfig,
   isSpecifiedScalarType,
   GraphQLNamedType,
+  Kind,
 } from 'graphql';
 
 import {
@@ -216,7 +217,16 @@ describe('merge schemas through transforms', () => {
         },
         Bookings_Booking: {
           property: {
-            selectionSet: '{ propertyId }',
+            selectionSet: () => ({
+              kind: Kind.SELECTION_SET,
+              selections: [{
+                kind: Kind.FIELD,
+                name: {
+                  kind: Kind.NAME,
+                  value: 'propertyId',
+                }
+              }]
+            }),
             resolve: (parent, _args, context, info) =>
               delegateToSchema({
                 schema: propertySubschema,