allow mutation type wrapping #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the blocker for this was that the default createProxyingResolverFn was changed to no longer hardcode the operation, but to rather infer it from the root type being stitched from. This was in parallel to a similar change with the target fieldName which was helpful when making the RenameRootField transformer just a special case of the RenameObjectField transformer, but messes up the wrapping of mutations, because when the root fields in the wrapping subschema are the ones that actually do the proxying, and wrapping them with another type causes them to default to the query operation. So, the default createProxyingResolverFn now hardcodes the operation, and all is well.
|
The latest changes of this PR are available as alpha in npm: Quickly update your package.json by running: |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the blocker for this was that the default createProxyingResolverFn was changed to no longer hardcode the operation, but to rather infer it from the root type being stitched from.
This was in parallel to a similar change with the target fieldName which was helpful when making the RenameRootField transformer just a special case of the RenameObjectField transformer, but messes up the wrapping of mutations, because when the root fields in the wrapping subschema are the ones that actually do the proxying, and wrapping them with another type causes them to default to the query operation.
So, the default createProxyingResolverFn now hardcodes the operation, and all is well.
Addresses #1708