Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow mutation type wrapping #1723

Merged
merged 1 commit into from
Jul 2, 2020
Merged

allow mutation type wrapping #1723

merged 1 commit into from
Jul 2, 2020

Commits on Jul 2, 2020

  1. allow mutation type wrapping 

    the blocker for this was that the default createProxyingResolverFn was changed to no longer hardcode the operation, but to rather infer it from the root type being stitched from.

This was in parallel to a similar change with the target fieldName which was helpful when making the RenameRootField transformer just a special case of the RenameObjectField transformer, but messes up the wrapping of mutations, because when the root fields in the wrapping subschema are the ones that actually do the proxying, and wrapping them with another type causes them to default to the query operation.

So, the default createProxyingResolverFn now hardcodes the operation, and all is well.
    @yaacovCR
    yaacovCR committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    bb7b86b View commit details
    Browse the repository at this point in the history