fix(createRequest): selectionSet overrides fieldNodes #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selectionSet option is used with bare execution, where fieldNodes is not present, without issue. with type merging, info.fieldNodes and fieldNodes may be specified, but selectionSet should override, as there may be situation when both appear but selectionSet desired, unlikely for them both to appear but fieldNodes to be desired, as fieldNodes is auto generated, and selectionSet is more likely to be created manually.
|
The latest changes of this PR are available as alpha in npm: Quickly update your package.json by running: |
|
@ardatan is this a breaking change for mesh in any way? |
|
Does not look like mesh uses selectionSet, perhaps because of this bug, so in theory cannot be breaking change for mesh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selectionSet option is used with bare execution, where fieldNodes is not present, without issue.
with type merging, info.fieldNodes and fieldNodes may be specified, but selectionSet should override, as there may be situation when both appear but selectionSet desired, unlikely for them both to appear but fieldNodes to be desired, as fieldNodes is auto generated, and selectionSet is more likely to be created manually.
TODO: