Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(createRequest): selectionSet overrides fieldNodes #1820

Merged
merged 1 commit into from
Jul 28, 2020
Merged

fix(createRequest): selectionSet overrides fieldNodes #1820

merged 1 commit into from
Jul 28, 2020

Commits on Jul 24, 2020

  1. fix(createRequest): selectionSet overrides fieldNodes 

    selectionSet option is used with bare execution, where fieldNodes is not present, without issue.

with type merging, info.fieldNodes and fieldNodes may be specified, but selectionSet should override, as there may be situation when both appear but selectionSet desired, unlikely for them both to appear but fieldNodes to be desired, as fieldNodes is auto generated, and selectionSet is more likely to be created manually.
    @yaacovCR
    yaacovCR committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    b49ccdb View commit details
    Browse the repository at this point in the history