Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type declaration for SchemaVisitor #1030

Closed
wants to merge 1 commit into from
Closed

Fix type declaration for SchemaVisitor #1030

wants to merge 1 commit into from

Conversation

rexxars
Copy link

@rexxars rexxars commented Dec 18, 2018

SchemaVisitor has two problems currently;

  1. It allows any string as key, instead of the predefined enum values.
  2. The return type says it cannot return null or undefined, which are both used and have logic applied to them (null removes, undefined recreates as-is)

This PR fixes these two problems so it is possible to use this for filtering types in a typescript project.

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change. Include a description of your change, link to PR (always) and issue (if applicable). Add your CHANGELOG entry under vNEXT. Do not create a new version number for your change yourself.

@yaacovCR
Copy link
Collaborator

yaacovCR commented Apr 1, 2020

Closed in favor of #1307

@yaacovCR yaacovCR closed this Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants