Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove '.' imports that break rollup (#924) #1049

Closed
wants to merge 2 commits into from

Conversation

gaberudy
Copy link
Contributor

Current code causes rollup to fail due to the circular dependencies introduced by the from '.' imports:

(!) Circular dependency: src/graphql_tools/generate/index.ts -> src/graphql_tools/generate/addResolveFunctionsToSchema.ts -> src/graphql_tools/generate/index.ts
(!) Circular dependency: src/graphql_tools/generate/index.ts -> src/graphql_tools/generate/assertResolveFunctionsPresent.ts -> src/graphql_tools/generate/index.ts
(!) Circular dependency: src/graphql_tools/generate/index.ts -> src/graphql_tools/generate/attachConnectorsToContext.ts -> src/graphql_tools/generate/index.ts
(!) Circular dependency: src/graphql_tools/generate/index.ts -> src/graphql_tools/generate/buildSchemaFromTypeDefinitions.ts -> src/graphql_tools/generate/index.ts
(!) Circular dependency: src/graphql_tools/generate/index.ts -> src/graphql_tools/generate/checkForResolveTypeResolver.ts -> src/graphql_tools/generate/index.ts
(!) Circular dependency: src/graphql_tools/generate/index.ts -> src/graphql_tools/generate/concatenateTypeDefs.ts -> src/graphql_tools/generate/index.ts

This changes the imports to use direct reference to "peers" instead of to the containing module (index.ts)

@apollo-cla
Copy link

@gaberudy: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@charlie-axsy
Copy link

@gaberudy I am also experiencing this issue. Are you still blocked by it? I see there has been no activity since you submitted the PR.

@gaberudy
Copy link
Contributor Author

@charlie-axsy Yes! I’m still blocked by this.

I have a forked and patched version of GraphQL-tools checked into our repo waiting for this patch to be upstreamed :)

@gaberudy
Copy link
Contributor Author

gaberudy commented May 1, 2019

The failed tests are just timeout failures that this pull request has nothing to do with.

Please merge these simple changes

@yaacovCR
Copy link
Collaborator

yaacovCR commented May 1, 2019

See #1102 which fixes the unrelated errors, can be merged to demonstrate whether all tests pass for pending pull requests.

@yaacovCR
Copy link
Collaborator

yaacovCR commented Apr 1, 2020

Closed in favor of #1307

@yaacovCR yaacovCR closed this Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants