Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] allow renaming of subscription root fields #1104

Closed

Conversation

yaacovCR
Copy link
Collaborator

@yaacovCR yaacovCR commented Apr 15, 2019

Fixes #997.

  • NA: If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change. Include a description of your change, link to PR (always) and issue (if applicable). Add your CHANGELOG entry under vNEXT. Do not create a new version number for your change yourself.

@yaacovCR
Copy link
Collaborator Author

New test added for this functionality passes.
Other tests fail because they are failing on master anyway, fixed separately in #1102.

@yaacovCR
Copy link
Collaborator Author

In addition to allowing explicit renaming of subscription fields, this fix should allow delegation of a subscription root field to another schema's subscription root field regardless of name. @benjamn, @hwillson, any thoughts?

@yaacovCR yaacovCR closed this Sep 24, 2019
@yaacovCR yaacovCR deleted the renameSubscriptionRootFields branch September 24, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscriptions not working if using RenameRootFields
1 participant