Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default merged resolver behavior for nullable fields #1172

Closed

Conversation

carmelid
Copy link

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change. Include a description of your change, link to PR (always) and issue (if applicable). Add your CHANGELOG entry under vNEXT. Do not create a new version number for your change yourself.

Closes #1171

Even though the contribution guidelines clearly states that there should be tests covering these sorts of bug fixes, I have not been able to write a test that reproduces the issue. Help and suggestions are very much appreciated (If we conclude this fix needs tests that is)

@apollo-cla
Copy link

@carmelid: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@carmelid
Copy link
Author

carmelid commented Aug 1, 2019

Ping @abernix @trevorblades @hwillson could anyone of you please take a look at this fix :)

@yaacovCR
Copy link
Collaborator

yaacovCR commented Apr 1, 2020

Closed in favor of implementation in #1307

Thanks for pointing this out!

@yaacovCR yaacovCR closed this Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

defaultMergedResolver unexpected behaviour for aliased and nullable fields
4 participants