Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/stiched errors extensions #1179

Closed

Conversation

carmelid
Copy link

@carmelid carmelid commented Aug 1, 2019

By using the GraphQLError constructor directly we are able to pass extensions through, as opposed to when using locatedError which does not produce a GraphQLError with extensions. This means that remote custom extensions can be passed through and not get lost along the way.

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes) (small change IMO)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change. Include a description of your change, link to PR (always) and issue (if applicable). Add your CHANGELOG entry under vNEXT. Do not create a new version number for your change yourself.

@carmelid
Copy link
Author

carmelid commented Aug 1, 2019

I also took the liberty to fix some of the tests that had been breaking. @abernix @trevorblades @hwillson

@yaacovCR
Copy link
Collaborator

yaacovCR commented Apr 1, 2020

Closed in favor of #1307

@yaacovCR yaacovCR closed this Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants